[GitHub] [kafka] hachikuji commented on pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-20 Thread GitBox
hachikuji commented on pull request #10157: URL: https://github.com/apache/kafka/pull/10157#issuecomment-782725727 I opened a separate PR for the `close()` bug fix: https://github.com/apache/kafka/pull/10168 This is an

[GitHub] [kafka] hachikuji commented on pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-19 Thread GitBox
hachikuji commented on pull request #10157: URL: https://github.com/apache/kafka/pull/10157#issuecomment-782330736 We are missing the handling of authentication and unsupported version exceptions in BrokerToControllerChannelManager. I am working on the test cases now and will submit an

[GitHub] [kafka] hachikuji commented on pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-18 Thread GitBox
hachikuji commented on pull request #10157: URL: https://github.com/apache/kafka/pull/10157#issuecomment-781825379 > Okay. I guess we need another KIP that explains how to upgrade a cluster and to determine when it is safe to enable the RaftClient on all of the brokers of a cluster.

[GitHub] [kafka] hachikuji commented on pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-18 Thread GitBox
hachikuji commented on pull request #10157: URL: https://github.com/apache/kafka/pull/10157#issuecomment-781799540 @jsancio I may be misunderstanding your question, but api versions are negotiated internally in `NetworkClient`. If there are no compatible versions, then the client will