[GitHub] [kafka] hachikuji commented on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

2021-06-04 Thread GitBox
hachikuji commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to invert the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "legacyVers

[GitHub] [kafka] hachikuji commented on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

2021-06-03 Thread GitBox
hachikuji commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to invert the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "legacyVers