hachikuji commented on PR #12124: URL: https://github.com/apache/kafka/pull/12124#issuecomment-1130386383
@konL Thanks for the PR. I would probably count this as "not agree and not fix". I think the renaming suggestion reads more awkwardly. Additionally, the references have not been updated, so we could not merge it as is anyway. Possibly `hasCompleted` or `isComplete` would work, but it does not seem any clearer than `isDone`. I will go ahead and close this PR, but please reopen if you think the change is worthwhile. If you do so, make sure to update references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
