hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1637307673
> @hudeqi Sorry, I think there's a misunderstanding here. I'm not claiming
that MM2 would be incapable of detecting changes in source cluster ACLs with
this change; I'm worried that it
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1635200263
Especially thanks for your separate reply! @C0urante I have tracked it in
the [Jira ticket](https://issues.apache.org/jira/browse/KAFKA-15172).
Going back to this PR, although it is
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1630624613
I would like to ask a question by the way: Why do we not synchronize the
write permission of `TopicAclBing` and `GroupAclBinding` in
MirrorSourceConnector? @C0urante @gharris1727
--
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1630082775
I have added the unit test for the related ”createAcl failure“ case, thanks
for the review! @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1625189960
pin again @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1618169057
Hi, I have updated, which show in unresolved conversation. @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1613529431
Hi! please help to review this PR when you are free, thank you! @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1606068264
If this improvement is reasonable, I will add related unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1606067371
@C0urante @mimaison Hi, please help to review this PR if you have time,
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
