[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r602917794 ## File path: build.gradle ## @@ -1423,18 +1423,8 @@ project(':streams') { dependencies { api project(':clients') -// use `api` dependency for

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r592000778 ## File path: build.gradle ## @@ -1635,8 +1627,14 @@ project(':streams:examples') { archivesBaseName = "kafka-streams-examples" dependencies { +

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r587502355 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r587501265 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r587501265 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586868205 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586715706 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586671249 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586670861 ## File path: build.gradle ## @@ -1403,12 +1403,7 @@ project(':streams') { dependencies { compile project(':clients') -// this dependency shou