[GitHub] [kafka] ijuma commented on a change in pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-21 Thread GitBox
ijuma commented on a change in pull request #10157: URL: https://github.com/apache/kafka/pull/10157#discussion_r579875328 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2244,7 +2244,6 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] ijuma commented on a change in pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-21 Thread GitBox
ijuma commented on a change in pull request #10157: URL: https://github.com/apache/kafka/pull/10157#discussion_r579875306 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -165,9 +165,19 @@ class DefaultAlterIsrManager( new

[GitHub] [kafka] ijuma commented on a change in pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-21 Thread GitBox
ijuma commented on a change in pull request #10157: URL: https://github.com/apache/kafka/pull/10157#discussion_r579875266 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -124,8 +124,14 @@ class KafkaNetworkChannel( } def

[GitHub] [kafka] ijuma commented on a change in pull request #10157: MINOR: Raft request thread should discover api versions

2021-02-20 Thread GitBox
ijuma commented on a change in pull request #10157: URL: https://github.com/apache/kafka/pull/10157#discussion_r579694847 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -124,8 +124,14 @@ class KafkaNetworkChannel( } def