ijuma commented on a change in pull request #9589: URL: https://github.com/apache/kafka/pull/9589#discussion_r566540886
########## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ########## @@ -256,6 +257,80 @@ public void testWorkerConfigs() { "secret2", bProps.get("producer.ssl.key.password")); } + @Test + public void testClusterPairsWithDefaultSettings() { + MirrorMakerConfig mirrorConfig = new MirrorMakerConfig(makeProps( + "clusters", "a, b, c")); + // implicit configuration associated + // a->b.enabled=false + // a->b.emit.heartbeat.enabled=true + // a->c.enabled=false + // a->c.emit.heartbeat.enabled=true + // b->a.enabled=false + // b->a.emit.heartbeat.enabled=true + // b->c.enabled=false + // b->c.emit.heartbeat.enabled=true + // c->a.enabled=false + // c->a.emit.heartbeat.enabled=true + // c->b.enabled=false + // c->b.emit.heartbeat.enabled=true + List<SourceAndTarget> clusterPairs = mirrorConfig.clusterPairs(); + assertEquals("clusterPairs count should match all combinations count", Review comment: I fixed the build via https://github.com/apache/kafka/commit/bf4afae8f53471ab6403cbbfcd2c4e427bdd4568 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org