[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-03 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r587191008 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,105 @@ public int sessionId() { * @param par

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-02 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585691505 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,79 +754,85 @@ class KafkaApis(val requestChannel: RequestChannel, // Fo

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-02 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585691505 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,79 +754,85 @@ class KafkaApis(val requestChannel: RequestChannel, // Fo

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-02 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585660962 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,98 @@ public int sessionId() { * @param part

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-02 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585656791 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -791,15 +791,17 @@ public void produceRequestGetErrorResp

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-03-01 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584812552 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -791,15 +791,18 @@ public void produceRequestGetErrorResp

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-27 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584172530 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +123,70 @@ public int sessionId() { * @param part

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-27 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584151716 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index look

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-27 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584142186 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index look

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-27 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584142074 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index look

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-27 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584141887 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index look

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-23 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r581069071 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +55,51 @@ * the fetch offset after the index look

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-23 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r581128378 ## File path: clients/src/main/resources/common/message/FetchResponse.json ## @@ -53,9 +53,9 @@ "about": "The response topics.", "fields": [ { "

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-02-23 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r581044552 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -290,7 +291,7 @@ public void onSuccess(ClientResponse resp

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-01-06 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552606639 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -142,19 +141,20 @@ class CachedPartition(val topic: String, if (updateResponseD

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-01-05 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552047139 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends Abs

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-01-05 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552043767 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends Abs

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

2021-01-04 Thread GitBox
ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r551412139 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -733,11 +733,11 @@ void resetOffsetIfNeeded(TopicPartition