[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig, try { followerTopicS

[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig, try { followerTopicS

[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994646630 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig, ): Unit = { stateChangeLogger.info