[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1062116212 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060836979 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060835881 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1060835881 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058623369 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058623037 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058615668 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058599006 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1211,50 +1184,50 @@ object KafkaConfig { .define(NumPartitionsProp, INT, Defaults.NumPartitions, atLe

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058580168 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -544,7 +544,7 @@ case class MetadataLogConfig(logSegmentBytes: Int, retentio

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058055018 ## storage/src/main/java/org/apache/kafka/server/log/internals/ThrottledReplicaListValidator.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation