inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-772381544
I was talking about build 17 (triggered by Commit db573f5, see
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9107/)
Where did build 18 came from, why it
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-771925298
Hi @mjsax , I have rebased and manually merged conflicts, and also removed
`FunctionConverters`
JDK8 build still fails, but this time much later -- something related to
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-771925298
Hi @mjsax , I have rebased and manually merged conflicts, and also removed
`FunctionConverters`
JDK8 build still fails, but this time much later -- something related to
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-769038641
Hi @mjsax , I have implemented all your suggestions concerning
Javadocs/Scaladocs.
After rebasing, there are less failing tests
I also see that `JDK8` build
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-768769254
> @inponomarev the failing tests seems to be due to a known issue that was
fixed via #9768
>
> Can you rebase your PR to pickup the fix so we can get a green build?
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-762937808
Ooops, I just noticed one more thing to fix:
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-762931868
Thank you @vvcephei, I have updated [the
KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream)
and now it reflects the
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-761803551
Hi @vvcephei thank you for your commits! Is everything else OK, especially
https://github.com/apache/kafka/pull/9107#issuecomment-666749809?
@mjsax I pushed small fixes
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-759644375
@vvcephei @mjsax I added full Scala wrapper for the new API: `split` method,
`BranchedKStream` and `Branched`. Also added Scala unit tests that verify main
use cases
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-758218461
Hi @vvcephei , thank you for your comment. There's another question that we
were unable to solve without you -- see
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752382595
As far as I can judge from the name, `@nowarn` is not for deprecation, but
rather for a warning suppression 樂 apparently we need to mirror the changes in
Java `KStream`
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752098770
> Can you also update the docs for Kafka Streams and the 2.8 upgrade guide
in this PR.
The documentation had been already updated (see changes in
12 matches
Mail list logo
