jasonyanwenl opened a new pull request #11297:
URL: https://github.com/apache/kafka/pull/11297


   Currently in `ConsoleConsumer`/`ProducerPerformance`/`ConsolePerformance`, 
we will not set `client.id` if it is not provided by the user. Simiarly to what 
we already did for 
`ConsoleProducer`([code](https://github.com/apache/kafka/blob/99b9b3e84f4e98c3f07714e1de6a139a004cbc5b/core/src/main/scala/kafka/tools/ConsoleProducer.scala#L96)),
 this PR will set a default value of `client.id` so that we can better support 
quota testing. The default value is shown as follows:
   * `client.id` in `ConsoleConsumer`: `console-consumer`
   * `client.id` in `ConsumerPerformance`: `perf-consumer-client`
   * `client.id` in `ProducerPerformance`: `perf-producer-client`
   
   New unit testings are added to test both default `client.id` and `client.id` 
provided by users
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to