[GitHub] [kafka] jeff303 commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2023-04-23 Thread via GitHub
jeff303 commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1519134568 Realistically, I am not going to have time to finish this one up, despite having spent a considerable amount of time months back. Hopefully some others can build upon what I discovered t

[GitHub] [kafka] jeff303 commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-24 Thread GitBox
jeff303 commented on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1078447241 Something I've learned, that I feel is not [adequately](https://github.com/mockito/mockito/wiki/Mockito-vs-EasyMock) covered by this wiki: EasyMock expectations seem to

[GitHub] [kafka] jeff303 commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-18 Thread GitBox
jeff303 commented on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1072841151 Made a bit more progress on this. Converting `testRebalance` took me a very long time (due to the different paradigm that Mockito uses versus Powermock). The lack of a Mockit