[GitHub] [kafka] jeffkbkim commented on pull request #10940: KAFKA-13007: KafkaAdminClient getListOffsetsCalls reuse cluster snapshot

2021-07-01 Thread GitBox
jeffkbkim commented on pull request #10940: URL: https://github.com/apache/kafka/pull/10940#issuecomment-872467503 @showuon thanks! on the time complexity, i think you may have missed the for-loop wrapped around. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jeffkbkim commented on pull request #10940: KAFKA-13007: KafkaAdminClient getListOffsetsCalls reuse cluster snapshot

2021-07-01 Thread GitBox
jeffkbkim commented on pull request #10940: URL: https://github.com/apache/kafka/pull/10940#issuecomment-872460573 i have renamed cluster() to buildCluster(). i will submit a separate PR for the benchmark -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] jeffkbkim commented on pull request #10940: KAFKA-13007: KafkaAdminClient getListOffsetsCalls reuse cluster snapshot

2021-06-29 Thread GitBox
jeffkbkim commented on pull request #10940: URL: https://github.com/apache/kafka/pull/10940#issuecomment-870768034 @ijuma @hachikuji thanks for the review. i'll add a benchmark, not too sure if there's any other way to test the performance. -- This is an automated message from the