jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1171393130
> I agree with @dajac that
[KAFKA-14013](https://issues.apache.org/jira/browse/KAFKA-14013) is much more
urgent. As far as I know @jnh5y is on vacation until the end of next week.
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1160686032
> @jnh5y Yeah, you cannot rely on providing the error in the response in
your case. Instead, you have to find a place where you can actually throw a
custom exception. That could be with a
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1160666884
@dajac Thanks for fixing the PR and merging it!
If that ticket can wait a little bit, I'd like to find the time to do it. I
can find time before the July 20th code freeze.
--
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1160665948
> @jnh5y I do not completely understand what you mean by:
>
> > I tried to find a way to create a unit test for this change, but I
wasn't able to do so quickly.
>
> I have the
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1159323680
> @jnh5y Have you been able to come up with a unit test?
I have not yet; I'm traveling a little bit. Don't let me hold up progress;
I'll make an effort to get to it next week.
--
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1156967918
I tried to find a way to create a unit test for this change, but I wasn't
able to do so quickly. If someone has a suggestion for how to do that, I'm
happy to follow through with it.
--
