[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-18 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r578577789 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1364,11 +1364,19 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-18 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r578577351 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -428,6 +428,35 @@ class Partition(val topicPartition: TopicPartition, this.lo

[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-17 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r578010946 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1364,34 +1364,59 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-17 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r578007354 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1364,34 +1364,59 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-17 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r577986110 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1364,34 +1364,59 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #10143: KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

2021-02-17 Thread GitBox
jolshan commented on a change in pull request #10143: URL: https://github.com/apache/kafka/pull/10143#discussion_r577985597 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1364,34 +1364,59 @@ class ReplicaManager(val config: KafkaConfig,