[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746873252 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746867390 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746836952 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746829235 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746807276 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746789815 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +935,341 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746785542 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2440,6 +2442,57 @@ class KafkaApisTest { assertNull(partitionData.abor

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746783340 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746220311 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746220127 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746217460 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -967,6 +967,113 @@ class FetchSessionTest { .setErrorCode(errorCod

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746100239 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive on

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746096126 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746077096 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,38 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746078020 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,38 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746077096 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,38 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r746038595 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive on

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745947154 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,25 +793,26 @@ class ReplicaManagerTest { // We receive on

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745943714 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -877,34 +921,182 @@ class FetchSessionTest { // Create an incremen

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745942320 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,125 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745941900 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,125 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745930497 ## File path: clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745925751 ## File path: clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745924906 ## File path: clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745867608 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745865347 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745864456 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745863973 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +432,182 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745182731 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -270,36 +273,320 @@ public void testFetchNormal()

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745091391 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745053425 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745033891 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -238,11 +237,13 @@ public String toString() { * inc

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r745010308 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -340,11 +340,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744906035 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744905470 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744883112 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -301,7 +299,9 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744880575 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744177445 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744138204 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r744138150 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743997732 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743983833 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int sendFetches

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743981159 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743979130 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743977547 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -305,9 +304,10 @@ class ReplicaFetcherThread(name: String, } else {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743976846 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743973792 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743973388 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743949497 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743841128 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -93,27 +93,42 @@ class CachedPartition(val topic: String, def this(topic: Strin

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743839587 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int sendFetches

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743839587 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int sendFetches

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743830862 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -66,16 +69,28 @@ public PartitionData( int maxB

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743830587 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -262,11 +262,12 @@ public synchronized int sendFetches

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370521 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370708 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala ## @@ -794,22 +793,23 @@ class ReplicaManagerTest { // We receive on

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743370419 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743369512 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -659,88 +670,108 @@ class FetchSessionTest { } @Test - def testI

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743365481 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -1091,18 +1089,20 @@ class AbstractFetcherThreadTest { ov

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743361897 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2069,10 +2071,10 @@ public void testReturnRecordsDuri

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743360648 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743357376 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743357376 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743355748 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743354926 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743351017 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -1361,102 +1542,113 @@ class FetchSessionTest { val resp4 = context2

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743350813 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -3530,37 +3534,37 @@ class KafkaApisTest { def testSizeOfThrottledPartiti

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743349370 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -4814,6 +4842,7 @@ private void buildDependencies(

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743349235 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -4814,6 +4842,7 @@ private void buildDependencies(

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243975 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243975 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743243111 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2659,6 +2661,9 @@ private FetchResponse fetchResponse

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743242849 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2069,10 +2071,10 @@ public void testReturnRecordsDuri

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743242346 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743241513 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743241204 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743240526 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743240074 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -428,82 +442,165 @@ public void testIdUsageRevokedOnIdDow

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r743239514 ## File path: clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java ## @@ -202,29 +203,30 @@ public void testSessionless() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742113471 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742113471 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742285803 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -163,18 +173,35 @@ class CachedPartition(val topic: String, mustRespond }

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742232425 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -66,16 +69,28 @@ public PartitionData( int maxB

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742121483 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1021,17 +1018,17 @@ class ReplicaManager(val config: KafkaConfig, var byte

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742119691 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel, None

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742116109 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742114292 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -824,6 +823,14 @@ static boolean hasUsableOffsetForLe

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r742113471 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r735935021 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r735935021 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -285,52 +268,57 @@ public FetchRequestData build() {

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r735863741 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -238,47 +247,40 @@ class FetchSession(val id: Int, def metadata: JFetchMetada

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r735854783 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -238,47 +247,40 @@ class FetchSession(val id: Int, def metadata: JFetchMetada

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728455837 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { * A

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r728455837 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -249,115 +215,126 @@ public String toString() { * A

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r719668223 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -378,53 +378,47 @@ class SessionlessFetchContext(val fetchData: util.Map[TopicPar

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r719649068 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -870,12 +868,14 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718910814 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -173,8 +184,8 @@ class CachedPartition(val topic: String, this.eq(that) |

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718912221 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -378,53 +378,47 @@ class SessionlessFetchContext(val fetchData: util.Map[TopicPar

[GitHub] [kafka] jolshan commented on a change in pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

jolshan commented on a change in pull request #11331: URL: https://github.com/apache/kafka/pull/11331#discussion_r718911636 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -173,8 +184,8 @@ class CachedPartition(val topic: String, this.eq(that) |

  1   2   >