[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r544634608 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1434,6 +1447,31 @@ class ReplicaManager(val config: KafkaConfig, */

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r544483664 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1434,6 +1447,31 @@ class ReplicaManager(val config: KafkaConfig, */

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r544483238 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1434,6 +1447,31 @@ class ReplicaManager(val config: KafkaConfig, */

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543691182 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543679600 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1021,6 +1036,13 @@ class Log(@volatile private var _dir: File, // re-initialize lead

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543663481 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1434,6 +1447,31 @@ class ReplicaManager(val config: KafkaConfig, */

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543488660 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1021,6 +1036,13 @@ class Log(@volatile private var _dir: File, // re-initialize lead

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543487703 ## File path: core/src/main/scala/kafka/server/PartitionMetadataFile.scala ## @@ -0,0 +1,141 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543485900 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540577792 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -138,14 +145,32 @@ public LeaderAndIsrResponse getError

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540537367 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540516535 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -138,14 +145,32 @@ public LeaderAndIsrResponse getError

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540513762 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540513762 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540510301 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java ## @@ -45,8 +47,16 @@ public LeaderAndIsrResponse(Struct str

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540354679 ## File path: core/src/test/scala/unit/kafka/controller/ControllerChannelManagerTest.scala ## @@ -157,7 +163,8 @@ class ControllerChannelManagerTest {

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540354106 ## File path: core/src/test/scala/unit/kafka/controller/ControllerChannelManagerTest.scala ## @@ -87,7 +90,10 @@ class ControllerChannelManagerTest {

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540311108 ## File path: clients/src/main/resources/common/message/LeaderAndIsrRequest.json ## @@ -21,8 +21,12 @@ // // Version 2 adds broker epoch and reorganiz

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540309740 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java ## @@ -45,8 +47,16 @@ public LeaderAndIsrResponse(Struct str

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r527812774 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1445,15 +1483,38 @@ class ReplicaManager(val config: KafkaConfig, repl