[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-26 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r564908486 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java ## @@ -68,6 +69,19 @@ protected CreateTopicsResult(Map> fu

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-26 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r564914537 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-27 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r565448192 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-27 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r565448514 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java ## @@ -68,6 +69,19 @@ protected CreateTopicsResult(Map> fu

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-27 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r565591713 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-27 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r565591713 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-27 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r565783921 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1843,6 +1843,8 @@ class KafkaApis(val requestChannel: RequestChannel, .

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-28 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r566487288 ## File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala ## @@ -15,12 +15,13 @@ * limitations under the License.

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2020-12-03 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r535743912 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1896,6 +1896,11 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2020-12-03 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r535743912 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1896,6 +1896,11 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2020-12-20 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r546406433 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1896,6 +1896,11 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2020-12-21 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r546852777 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java ## @@ -68,6 +69,19 @@ protected CreateTopicsResult(Map> fu

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550904963 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -621,10 +621,10 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905081 ## File path: clients/src/main/resources/common/message/DeleteTopicsRequest.json ## @@ -23,10 +23,17 @@ // // Version 5 adds ErrorMessage in the respo

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905106 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1623,6 +1625,32 @@ public DeleteTopicsResult deleteTopics(f

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905278 ## File path: clients/src/main/java/org/apache/kafka/common/requests/DeleteTopicsRequest.java ## @@ -39,8 +45,25 @@ public Builder(DeleteTopicsRequestData

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905654 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1981,29 +1986,39 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550906325 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -621,10 +621,10 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-04 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r551475961 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1981,29 +1986,39 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-06 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r552856176 ## File path: core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala ## @@ -132,6 +133,25 @@ class DeleteTopicsRequestTest extends BaseRequestT