[GitHub] [kafka] jolshan commented on a diff in pull request #12121: Kafka 13846: Adding overloaded metricOrElseCreate method

2022-05-06 Thread GitBox
jolshan commented on code in PR #12121: URL: https://github.com/apache/kafka/pull/12121#discussion_r867226334 ## clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java: ## @@ -524,6 +524,58 @@ public void addMetric(MetricName metricName, MetricValueProvider metricVa

[GitHub] [kafka] jolshan commented on a diff in pull request #12121: Kafka 13846: Adding overloaded metricOrElseCreate method

2022-05-06 Thread GitBox
jolshan commented on code in PR #12121: URL: https://github.com/apache/kafka/pull/12121#discussion_r867226487 ## clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java: ## @@ -563,10 +615,15 @@ public synchronized void removeReporter(MetricsReporter reporter) {