[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-05-26 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1206991344 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important g

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-18 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1170250900 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important g

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-11 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1163210151 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Grou

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-05 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1158947529 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Grou

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-05 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1158817715 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -291,24 +291,24 @@ private[group] class GroupCoordinatorAdapter( topics: util.L

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-05 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1158816855 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Grou

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-04-05 Thread via GitHub
jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1158813853 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -291,24 +291,24 @@ private[group] class GroupCoordinatorAdapter( topics: util.L