[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1183188070 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,8 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180865066 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -222,6 +223,27 @@ public void clearPartitionRecords() { partitionSizes();

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180864382 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -642,7 +642,14 @@ class ReplicaManager(val config: KafkaConfig, (entriesPerPartition,

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1180864129 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -222,6 +223,27 @@ public void clearPartitionRecords() { partitionSizes();

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1172068360 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel,