[GitHub] [kafka] jolshan commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
jolshan commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1269711912 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -31,13 +31,19 @@ // version 7 adds a new field called groupInstanceId to indicate

[GitHub] [kafka] jolshan commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-19 Thread via GitHub
jolshan commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1268350437 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -89,33 +88,29 @@ public Map offsets() { return offsets; } -