[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1311819184 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1452,62 +1452,63 @@ class KafkaApis(val requestChannel: RequestChannel, private def fetchAllOffsetsForG

[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1311799178 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -170,29 +170,27 @@ CompletableFuture delet * Fetch offsets for

[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1310562460 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -183,20 +183,21 @@ public List fetchOffsets( l

[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1310562460 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -183,20 +183,21 @@ public List fetchOffsets( l

[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1310545133 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1452,62 +1452,63 @@ class KafkaApis(val requestChannel: RequestChannel, private def fetchAllOffsetsForG

[GitHub] [kafka] jolshan commented on a diff in pull request #14310: KAFKA-14499: [5/N] Refactor GroupCoordinator.fetchOffsets and GroupCoordinator.fetchAllOffsets

jolshan commented on code in PR #14310: URL: https://github.com/apache/kafka/pull/14310#discussion_r1310545133 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1452,62 +1452,63 @@ class KafkaApis(val requestChannel: RequestChannel, private def fetchAllOffsetsForG