[GitHub] [kafka] jolshan commented on a diff in pull request #14324: KAFKA-15424: Make the transaction verification a dynamic configuration

[via GitHub]

jolshan commented on code in PR #14324:
URL: https://github.com/apache/kafka/pull/14324#discussion_r1314325008


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##########
@@ -16,12 +16,19 @@
  */
 package org.apache.kafka.storage.internals.log;
 
-import java.util.Collections;
+import java.util.HashSet;
 import java.util.Set;
 
 public class ProducerStateManagerConfig {
     public static final String PRODUCER_ID_EXPIRATION_MS = 
"producer.id.expiration.ms";
-    public static final Set<String> RECONFIGURABLE_CONFIGS = 
Collections.singleton(PRODUCER_ID_EXPIRATION_MS);
+    public static final String TRANSACTION_VERIFICATION_ENABLED = 
"transaction.partition.verification.enable";
+    private static final Set<String> RECONFIGURABLE_CONFIGS;
+
+    static {
+        RECONFIGURABLE_CONFIGS = new HashSet<>();
+        RECONFIGURABLE_CONFIGS.add(PRODUCER_ID_EXPIRATION_MS);
+        RECONFIGURABLE_CONFIGS.add(TRANSACTION_VERIFICATION_ENABLED);
+    }
 
     private volatile int producerIdExpirationMs;
     private boolean transactionVerificationEnabled;

Review Comment:
   Ah fair point. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org