[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

2023-03-07 Thread via GitHub
jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1458557507 for follow ups: https://issues.apache.org/jira/browse/KAFKA-14790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

2023-02-22 Thread via GitHub
jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1441095454 Took a quick look at the unstable api change. Looks like some integration tests built specifically for v4 fail with `org.apache.kafka.common.errors.InvalidRequestException: Received reque

[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

2023-02-22 Thread via GitHub
jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1441071519 I've added the changes to the API spec -- verify only is now a transaction level config -- top level error is added to the response I've added builders to the request and tried