[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-03 Thread via GitHub
jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1533922748 haven't updated the base in a while, so merging so that we can hopefully get a cleaner build. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-04-28 Thread via GitHub
jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1528168395 One concern that came up when I was thinking about this PR is if we can have a produce request with more than one producer ID when we overflow epoch. Basically, I need to confirm we

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-04-19 Thread via GitHub
jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-151533 I believe the connect mirror failures are known -- so no issues from the testing front. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-04-18 Thread via GitHub
jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1513675548 I already see the checkstyle issues created by my IDE so I will fix in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on