[GitHub] [kafka] jolshan commented on pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
jolshan commented on PR #13675: URL: https://github.com/apache/kafka/pull/13675#issuecomment-1577150595 These connect tests are a little concerning. They seem unrelated but maybe we should file a jira. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan commented on pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-02 Thread via GitHub
jolshan commented on PR #13675: URL: https://github.com/apache/kafka/pull/13675#issuecomment-1574008136 Hey David -- whenever we update appendRecords we have to modify a ton of tests that mock the method. (Basically add a ton of any(), since the mocker doesn't get default args). There are 2