jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-887966371
@dengziming -- @rajinisivaram can help in about 2 weeks. I will try to help
review so it will be ready when she gets to it.
--
This is an automated message from the Apache Git S
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-874862869
Looks like some deprecated methods should be replaced.
```
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9769/connect/mirror/src/main/java/org/apache/kafka/connect
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-870786796
Hi again @dengziming. There was one more change to the API (should be the
last one this time). It includes adding a new class that I implement in this
PR: https://github.com/apach
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-865491775
Hi @dengziming thanks for the update. There are a few more minor changes to
the KIP.
One is that after some discussion with people more familiar with clients, it
makes sense to
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-865491775
Hi @dengziming thanks for the update. There are a few more minor changes to
the KIP.
One is that after some discussion with people more familiar with clients, it
makes sense to
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-772830472
@dengziming I don't know if you saw the mailing list discussion on this KIP,
but the summary is that I talked to Ismael offline and we thought it would be
good to hold off on the
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-769200848
Thanks for the update. The test case is good. In general, LGTM
This is an automated message from the Apache Git Se
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-766972011
I added a few comments. Mostly just questions for clarification.
This is an automated message from the Apache Git
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-766972011
I added a few comments. Mostly just questions for clarification.
This is an automated message from the Apache Git
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-764014519
@dengziming I realized that for this, it really depends on the IBP of the
controller. (That is, we need UpdateMetadata to send topic IDs to all the
brokers). So maybe instead of c
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-764014519
@dengziming I realized that for this, it really depends on the IBP of the
controller. (That is, we need UpdateMetadata to send topic IDs to all the
brokers). So maybe instead of c
11 matches
Mail list logo
