[GitHub] [kafka] jsancio commented on a change in pull request #10138: KAFKA-12331: Use LEO for the base offset of LeaderChangeMessage batch

2021-02-17 Thread GitBox
jsancio commented on a change in pull request #10138: URL: https://github.com/apache/kafka/pull/10138#discussion_r577972986 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -106,7 +106,8 @@ public void testFetchRequestWithLargerLast

[GitHub] [kafka] jsancio commented on a change in pull request #10138: KAFKA-12331: Use LEO for the base offset of LeaderChangeMessage batch

2021-02-17 Thread GitBox
jsancio commented on a change in pull request #10138: URL: https://github.com/apache/kafka/pull/10138#discussion_r577868426 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -250,30 +249,7 @@ private LogEntry buildEntry(Long offset, SimpleRecord record)

[GitHub] [kafka] jsancio commented on a change in pull request #10138: KAFKA-12331: Use LEO for the base offset of LeaderChangeMessage batch

2021-02-17 Thread GitBox
jsancio commented on a change in pull request #10138: URL: https://github.com/apache/kafka/pull/10138#discussion_r577868426 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -250,30 +249,7 @@ private LogEntry buildEntry(Long offset, SimpleRecord record)