[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r640805609 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -963,6 +952,20 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r637470950 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,25 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r622425656 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,57 @@ public void testFetchSnapshotRequestCl

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r620232416 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r620232416 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619882084 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619882204 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,51 @@ public void testFetchSnapshotRequestCl

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r619882084 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean