[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-30 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r462489390 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -2090,6 +2093,12 @@ case class ReplicaLeaderElection( callback:

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460468239 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -77,7 +77,7 @@ class ControllerEventManager(controllerId: Int,

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460468241 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460467261 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -598,6 +603,86 @@ class ControllerIntegrationTest extends

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-22 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r458979257 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -598,6 +603,86 @@ class ControllerIntegrationTest extends