[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535482262 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -74,18 +74,19 @@ public void freeze() throws IOException {

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-03 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r535474040 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534592624 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -100,4 +102,15 @@ default void handleResign() {} */ CompletableFutur

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534587344 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534581287 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -472,4 +489,110 @@ private EpochStartOffset(int epoch, long startOffset) {

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534577659 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534572296 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-02 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r534489751 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -100,4 +102,15 @@ default void handleResign() {} */ CompletableFutur

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-01 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r533835857 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java ## @@ -149,6 +152,29 @@ default OptionalLong truncateToEndOffset(OffsetAndEpoch e

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-01 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r533833428 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-01 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r533829583 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-01 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r533828329 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -100,4 +102,15 @@ default void handleResign() {} */ CompletableFutur

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-07 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r519213671 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-07 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r519211721 ## File path: raft/src/main/java/org/apache/kafka/snapshot/RawSnapshotReader.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-07 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r519211586 ## File path: raft/src/main/java/org/apache/kafka/snapshot/RawSnapshotWriter.java ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-07 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r519211390 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -32,25 +32,25 @@ * This class is responsible for managing the current state

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-06 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r518916392 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-05 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r518396177 ## File path: core/src/main/scala/kafka/snapshot/KafkaSnapshotReader.scala ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703078 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703953 ## File path: raft/src/main/java/org/apache/kafka/snapshot/BatchedSnapshotWriter.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703625 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517703078 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-04 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r517672247 ## File path: core/src/main/scala/kafka/snapshot/KafkaSnapshotReader.scala ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde