[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890595884 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -485,12 +541,36 @@ Iterator usableBrokers() { id -> brokerRegistrati

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890548627 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -152,13 +156,22 @@ public boolean fenced() { return fenced; } -pub

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890549624 ## metadata/src/main/resources/common/metadata/BrokerRegistrationChangeRecord.json: ## @@ -17,14 +17,16 @@ "apiKey": 17, "type": "metadata", "name": "BrokerRegi

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890548627 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -152,13 +156,22 @@ public boolean fenced() { return fenced; } -pub

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890540775 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -682,25 +683,35 @@ private ApiError createTopic(CreatableTopic topic,

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890538379 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -132,15 +143,27 @@ ClusterControlManager build() { replicaPlacer

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r889716710 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -444,6 +481,46 @@ public void testCreateTopics() throws Exception {