[GitHub] [kafka] jsancio commented on a diff in pull request #12715: MINOR: Refactor KRaft image generation

2022-10-12 Thread GitBox
jsancio commented on code in PR #12715: URL: https://github.com/apache/kafka/pull/12715#discussion_r993773605 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -179,8 +184,13 @@ class BrokerMetadataListener( snapshotter.foreach { snapshotter

[GitHub] [kafka] jsancio commented on a diff in pull request #12715: MINOR: Refactor KRaft image generation

2022-10-06 Thread GitBox
jsancio commented on code in PR #12715: URL: https://github.com/apache/kafka/pull/12715#discussion_r989546700 ## metadata/src/main/java/org/apache/kafka/image/ImageWriter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *