[GitHub] [kafka] jsancio commented on a diff in pull request #13058: KAFKA-14557; Lock metadata log dir

2023-01-04 Thread GitBox
jsancio commented on code in PR #13058: URL: https://github.com/apache/kafka/pull/13058#discussion_r1061930398 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -154,6 +192,8 @@ class KafkaRaftManager[T]( scheduler.shutdown() netChannel.close() replicated

[GitHub] [kafka] jsancio commented on a diff in pull request #13058: KAFKA-14557; Lock metadata log dir

2023-01-04 Thread GitBox
jsancio commented on code in PR #13058: URL: https://github.com/apache/kafka/pull/13058#discussion_r1061928077 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -81,25 +100,99 @@ class RaftManagerTest { ) } - @Test - def testNodeIdPresentIfBrokerRol