[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218103438 ## core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: ## @@ -1456,6 +1456,105 @@ class PartitionTest extends AbstractPartitionTest { assertEquals(alterPar

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition, // Note here we are using the

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218098813 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -260,11 +265,17 @@ private void tryElection(PartitionChangeRecord record) {

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218088303 ## core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala: ## @@ -357,6 +363,51 @@ abstract class BaseProducerSendTest extends KafkaServerTestHarness {

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition, // Note here we are using the

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-05 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition, // Note here we are using the

[GitHub] [kafka] jsancio commented on a diff in pull request #13765: KAFKA-15021; Skip leader epoch bump on ISR shrink

2023-06-01 Thread via GitHub
jsancio commented on code in PR #13765: URL: https://github.com/apache/kafka/pull/13765#discussion_r1213501789 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1087,12 +1087,14 @@ class Partition(val topicPartition: TopicPartition, // avoid unnecessary collectio