[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-06-03 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-638286953 The bug report in [KAFKA-9962](https://issues.apache.org/jira/browse/KAFKA-9962) is for `describeCluster`. This

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-06-02 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-637749796 > Well, the client can handle the `UnsupportedVersionException and stop requesting the authorized operations. This is not fine grain enough for all cases. There are already

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-29 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-636256515 > In the case described in this JIRA, KSQL is requesting authorized operations from a broker that doesn't support it. What is it going to do if we don't throw an exception and qui

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-29 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-636255975 > The system test client_compatibility_features_test.py (also see ClientCompatibilityTest.java). Done. Thi

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-28 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-635524753 > One observation is, we were not throwing exception in 2.3 and 2.4 releases. This was enforced in #7710 (2.5 release) Thanks @omkreddy and sorry for the delay response.

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-09 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-626264546 > > > Thanks for the PR. I think we should update the admin client compatibility test to include this. @ijuma, I am not sure I follow. Do you mean these kind of test

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-09 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-626254232 @omkreddy When we merge this we need to cherry pick this to the versions enumerated in the Jira. This is an autom