[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-03 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r587131740 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +359,29 @@ public void replay(PartitionChange

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-03 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r586990075 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +359,29 @@ public void replay(PartitionChange

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-03 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r586880128 ## File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala ## @@ -18,19 +18,26 @@ package unit.kafka.server Review comment: This

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584019199 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChange

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583984728 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChange