[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-27 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r621652737 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618761439 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617858509 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String diff(PartitionControlInfo

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617773890 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-20 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617093936 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,61 @@ void

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-19 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r616258845 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1039,77 @@ void