[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-18 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r690492221 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -113,7 +113,7 @@ class BrokerServer( var dynamicConfigHandlers: Map[String, Co

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-17 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r690492221 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -113,7 +113,7 @@ class BrokerServer( var dynamicConfigHandlers: Map[String, Co

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-16 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689974956 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2074,48 +2073,23 @@ class ReplicaManager(val config: KafkaConfig, } }

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-16 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689907759 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String na

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-16 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689841279 ## File path: metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java ## @@ -126,6 +133,158 @@ private static TopicImage newTopicImage(String na

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-16 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r689659905 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -162,4 +163,39 @@ public boolean topicWasDeleted(String topicName) {