[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r715068733 ## File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala ## @@ -141,9 +145,14 @@ class KafkaScheduler(val threads: Int, executor != null

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r714283329 ## File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala ## @@ -53,7 +53,7 @@ trait Scheduler { * @param unit The unit for the preceding time

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r714186270 ## File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala ## @@ -107,7 +107,10 @@ class KafkaScheduler(val threads: Int, debug("Scheduling ta

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r714188175 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -482,6 +482,20 @@ class BrokerServer( } metadataSnapshotter.foreach(s

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r714188175 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -482,6 +482,20 @@ class BrokerServer( } metadataSnapshotter.foreach(s

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713494615 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713478871 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager