[GitHub] [kafka] junrao commented on a change in pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-26 Thread GitBox
junrao commented on a change in pull request #9364: URL: https://github.com/apache/kafka/pull/9364#discussion_r512317288 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -978,10 +1051,10 @@ class LogTest { producerIdExpirationCheckIntervalMs = 3,

[GitHub] [kafka] junrao commented on a change in pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-23 Thread GitBox
junrao commented on a change in pull request #9364: URL: https://github.com/apache/kafka/pull/9364#discussion_r510527544 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -298,26 +300,38 @@ class LogManager(logDirs: Seq[File], /** * Recover and load all

[GitHub] [kafka] junrao commented on a change in pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-02 Thread GitBox
junrao commented on a change in pull request #9364: URL: https://github.com/apache/kafka/pull/9364#discussion_r499051238 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -244,7 +244,8 @@ class Log(@volatile private var _dir: File, val producerIdExpirationC