[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r661822644 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -296,11 +276,23 @@ public AbstractResponse

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r661716207 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -296,11 +276,23 @@ public AbstractResponse

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660016282 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -193,18 +197,22 @@ class CachedPartition(val topic: String, * Each fetch session

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660211602 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +512,26 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660016282 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -193,18 +197,22 @@ class CachedPartition(val topic: String, * Each fetch session

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655561404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655561404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651977071 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached partition

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651976677 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651939380 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached partition

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r649585182 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -817,20 +839,26 @@ class KafkaApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r625422142 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time,

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r617932245 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -662,11 +662,21 @@ class KafkaApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r573102028 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,50 +508,68 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r572512463 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -353,50 +508,68 @@ class SessionlessFetchContext(val fetchData:

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r568140154 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -37,7 +38,10 @@ object FetchSession { type REQ_MAP = util.Map[TopicPartition,