[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r886228739 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -158,14 +158,29 @@ class ServerShutdownTest extends KafkaServerTestHarness { @ParameterizedT

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r880990528 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -158,22 +192,37 @@ class LogLoaderTest { } locally { + val (logManager, runLoadLogs) =

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r879690436 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -134,10 +154,29 @@ class LogLoaderTest { } } +def initializeLogManagerForSimulatingErro

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r871593948 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -376,8 +381,10 @@ class LogManager(logDirs: Seq[File], s"($currentNumLoaded/${logsToLoad.length}