[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1294877936 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -267,11 +307,14 @@ public synchronized void update(int requestVersion, MetadataResponse

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1294883198 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -140,17 +172,34 @@ public long metadataExpireMs() { } /** - * Request an update

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1294873505 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -114,18 +125,39 @@ public synchronized Cluster fetch() { /** * Return the next time

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1291575101 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -114,18 +127,41 @@ public synchronized Cluster fetch() { /** * Return the next time

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1290474356 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -140,17 +167,30 @@ public long metadataExpireMs() { } /** - * Request an update

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1288946333 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -144,13 +159,25 @@ public long metadataExpireMs() { */ public synchronized int

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1286480033 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -613,7 +623,7 @@ private long batchReady(long nowMs, boolean

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1282312134 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -73,6 +75,7 @@ public class RecordAccumulator { private final

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1278072179 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1488,9 +1500,10 @@ public void run() { }