[GitHub] [kafka] junrao commented on a diff in pull request #14308: KAFKA-14965 - OffsetsRequestsManager implementation & API integration

2023-08-31 Thread via GitHub
junrao commented on code in PR #14308: URL: https://github.com/apache/kafka/pull/14308#discussion_r1312321020 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java: ## @@ -0,0 +1,675 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] junrao commented on a diff in pull request #14308: KAFKA-14965 - OffsetsRequestsManager implementation & API integration

2023-08-30 Thread via GitHub
junrao commented on code in PR #14308: URL: https://github.com/apache/kafka/pull/14308#discussion_r1310575529 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] junrao commented on a diff in pull request #14308: KAFKA-14965 - OffsetsRequestsManager implementation & API integration

2023-08-30 Thread via GitHub
junrao commented on code in PR #14308: URL: https://github.com/apache/kafka/pull/14308#discussion_r1309440032 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation