[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-10 Thread GitBox
junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-777104678 @jolshan : It seems this PR can't be applied cleanly in 2.8. Could you submit a separate PR for 2.8? Thanks. Thi

[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-10 Thread GitBox
junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-777054798 @jolshan : Do you have any benchmark results that you want to share? This is an automated message from the Apache

[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-10 Thread GitBox
junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-776872795 @jolshan Could you rebase the PR for trunk? Also, I am not sure if the PR ports to 2.8 cleanly, if not, could you submit a separate PR for 2.8? Thanks. -

[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-09 Thread GitBox
junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-776328567 @jolshan : Thanks. Were the JDK 8 tests ok too? This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] junrao commented on pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-09 Thread GitBox
junrao commented on pull request #10041: URL: https://github.com/apache/kafka/pull/10041#issuecomment-776303090 @jolshan : Thanks. For those transient failures, could you file a jira if it's not tracked already? Are the JDK 8 failures also transient? ---