[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1320065640 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319880229 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319880229 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319873450 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -179,6 +180,8 @@ public List read() { private final UnifiedLog mockLog = mock(UnifiedLog

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318027295 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318027295 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318024091 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318024091 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318027295 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318024091 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318024091 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1318024091 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1006,6 +1005,10 @@ private void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,