[GitHub] [kafka] kirktrue commented on a diff in pull request #12945: KAFKA-14365: Refactor Fetcher to allow different implementations

2022-12-13 Thread GitBox
kirktrue commented on code in PR #12945: URL: https://github.com/apache/kafka/pull/12945#discussion_r1047806698 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsFinder.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kirktrue commented on a diff in pull request #12945: KAFKA-14365: Refactor Fetcher to allow different implementations

2022-12-07 Thread GitBox
kirktrue commented on code in PR #12945: URL: https://github.com/apache/kafka/pull/12945#discussion_r1042805066 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsFinder.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kirktrue commented on a diff in pull request #12945: KAFKA-14365: Refactor Fetcher to allow different implementations

2022-12-06 Thread GitBox
kirktrue commented on code in PR #12945: URL: https://github.com/apache/kafka/pull/12945#discussion_r1041415886 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsFinder.java: ## @@ -0,0 +1,805 @@ +/* + * Licensed to the Apache Software Foundation (ASF)